Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verifier bails instead of automatically fetching certificate from KDS #456

Closed
AdithyaKrishnan opened this issue Aug 2, 2024 · 4 comments
Labels

Comments

@AdithyaKrishnan
Copy link
Contributor

The mod.rs code in verifier currently prints a statement that it Could not find either VCEK or VLEK in cert chain instead of automatically fetching it from the KDS

@mkulke
Copy link
Contributor

mkulke commented Aug 8, 2024

The mod.rs code in verifier currently prints a statement that it Could not find either VCEK or VLEK in cert chain instead of automatically fetching it from the KDS

Afaik KDS has a rate-limit, that would made it unreliable to use it by default. The VCEK/VLEK should be in the SNP-attester's evidence?

@mkulke mkulke added the sev-snp label Aug 8, 2024
@Doctor-love
Copy link

Afaik KDS has a rate-limit, that would made it unreliable to use it by default. The VCEK/VLEK should be in the SNP-attester's evidence?

If I understand you correctly, the "extended attestation workflow" as described in this issue comment is required in the current implementation of the verifier? Or is there some other way this is meant to work?

@mkulke
Copy link
Contributor

mkulke commented Sep 2, 2024

I think that's how it's supposed to work. The VCEK could be cached in multiple places (like a cloud's IMDS), but the public KDS service is occasionally not available, so I'd be cautious to build an architecture around it. We could still have a local memory cache on trustee for VCEKs maybe.

@fitzthum
Copy link
Member

fitzthum commented Sep 3, 2024

Apparently the latest upstream host patches no longer support setting the extended report (which the verifier currently requires), so we should make sure we implement some kind of fallback. If the AS reaches out to the KDS, it should cache the responses to avoid doing it too often.

@fitzthum fitzthum moved this to We have a plan in Trustee Roadmap Oct 21, 2024
@fitzthum fitzthum moved this from We have code to We did it in Trustee Roadmap Nov 27, 2024
@github-project-automation github-project-automation bot moved this from We did it to We have a requirement in Trustee Roadmap Nov 27, 2024
@fitzthum fitzthum moved this from We have a requirement to We did it in Trustee Roadmap Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: We did it
Development

No branches or pull requests

4 participants