Add commitCb method #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to avoid blocking while committing and return a Promise without having to call consumer
milindl
approved these changes
Dec 12, 2023
lib/kafkajs/_consumer.js
Outdated
| @@ -326,24 +326,32 @@ class Consumer { | |||
| * @param {import("../../types/kafkajs").TopicPartitionOffsetAndMetadata[]?} topicPartitions | |||
| * @returns {Promise<void>} a promise that resolves when the offsets have been committed. | |||
| */ | |||
| async commitOffsets(topicPartitions = null) { | |||
| commitOffsets(topicPartitions = null) { | |||
There was a problem hiding this comment.
We should keep it async to meet the kafkajs API, and it'll work since we're returning a promise anyway
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to avoid blocking while committing
and return a Promise without having
to call consume()