Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

librdkafka does not compile cleanly on AIX (using gcc/g++) #328

Closed
shalstea opened this issue Jul 8, 2015 · 6 comments
Closed

librdkafka does not compile cleanly on AIX (using gcc/g++) #328

shalstea opened this issue Jul 8, 2015 · 6 comments

Comments

@shalstea
Copy link
Contributor

shalstea commented Jul 8, 2015

I have patches for this but am waiting for fixes to the dev branch. On the dev branch the current code does not compile cleanly with older versions of gcc / the linux OS.

@edenhill
Copy link
Contributor

edenhill commented Jul 8, 2015

Which is issue #319

@shalstea
Copy link
Contributor Author

I am struggling to figure out the best way to do this. I have made code changes to port the library to AIX (in the dev branch) however the mklove build tool needs work for both AIX and Solaris and I have had to hack around this for now. The solaris build crashes in the tests and I haven't tried to even build/link on AIX since the solaris executables don't work.

would you be open to me:

  1. Submit the current changes for AIX - which are modest... knowing that it isn't complete
  2. Providing a list of suggested compiler/linker options to mklove that you would need to integrate

-- when you have done #1 and #2 above I would clone the dev branch and try building testing again

@edenhill
Copy link
Contributor

Absolutely, that sounds like a good plan.
Go ahead and submit some PRs for your work.

Big thanks for your effort!

@edenhill
Copy link
Contributor

edenhill commented Sep 8, 2015

@shalstea What's the status on this?

@shalstea
Copy link
Contributor Author

shalstea commented Sep 8, 2015

It now compiles cleanly (in dev branch). You can close this.

@edenhill
Copy link
Contributor

edenhill commented Sep 8, 2015

awesome, thanks

@edenhill edenhill closed this as completed Sep 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants