Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let user function throw retry exception, instead of raw errors which pollute log #242

Closed
2 tasks done
Tracked by #172 ...
astubbs opened this issue Mar 23, 2022 · 2 comments · Fixed by #444
Closed
2 tasks done
Tracked by #172 ...

Let user function throw retry exception, instead of raw errors which pollute log #242

astubbs opened this issue Mar 23, 2022 · 2 comments · Fixed by #444
Assignees
Milestone

Comments

@astubbs
Copy link
Contributor

astubbs commented Mar 23, 2022

  • Upgrade all tests to throw the retriable error where appropriate, to reduce error noise in test logs
  • also include exception to skip the message

ATM, all exceptions thrown from user logs as ERROR and causes retry.

User should be able to catch exception, and rethrow a retriable exception which doesn't get logged by PC.

Be able to signify a retry to the system, without registering an ERROR - currently ERRORs must be thrown to make the system retry, but an actual RetriableException would make logs much better because we'll be able to distinguish between actual unexpected errors in user function execution, and retriable vs unretriable errors as decided by the user.

@astubbs
Copy link
Contributor Author

astubbs commented Oct 21, 2022

@astubbs astubbs closed this as completed Oct 21, 2022
@astubbs
Copy link
Contributor Author

astubbs commented Oct 21, 2022

Will be released in 0.5.2.4

@astubbs astubbs self-assigned this Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant