Skip to content

Commit

Permalink
fix(icons): Use .png over .svg for icons for firefox
Browse files Browse the repository at this point in the history
  • Loading branch information
mwfarb committed Apr 19, 2022
1 parent 04a21c0 commit e7aa585
Show file tree
Hide file tree
Showing 15 changed files with 7 additions and 99 deletions.
2 changes: 1 addition & 1 deletion index.html
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ <h3><img alt="CONIX Logo" class="title-logo" src="static/images/xr-logo-v7.png"/
</div>

<div class="error-icon" id="error-icon">
<img id="error-svg" src="/src/health/images/exclamation.svg">
<img id="error-svg" src="/src/health/images/exclamation-error.png">
<div id="error-block" class="error-block"></div>
</div>
<span class="echo-name" id="echo-name"></span>
Expand Down
8 changes: 4 additions & 4 deletions src/components/arena-user.js
Original file line number Diff line number Diff line change
Expand Up @@ -232,13 +232,13 @@ AFRAME.registerComponent('arena-user', {

getQualityIcon(quality) {
if (quality > 66.7) {
return 'url(/src/icons/images/signal-good.svg)';
return 'url(/src/icons/images/signal-good.png)';
} else if (quality > 33.3) {
return 'url(/src/icons/images/signal-poor.svg)';
return 'url(/src/icons/images/signal-poor.png)';
} else if (quality > 0) {
return 'url(/src/icons/images/signal-weak.svg)';
return 'url(/src/icons/images/signal-weak.png)';
} else {
return 'url(/src/icons/images/signal-bad.svg)';
return 'url(/src/icons/images/signal-bad.png)';
}
},

Expand Down
Binary file added src/health/images/exclamation-error.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added src/health/images/exclamation-warn.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
44 changes: 0 additions & 44 deletions src/health/images/exclamation-warn.svg

This file was deleted.

44 changes: 0 additions & 44 deletions src/health/images/exclamation.svg

This file was deleted.

4 changes: 2 additions & 2 deletions src/health/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -60,10 +60,10 @@ export class ARENAHealth {
const icon = document.getElementById('error-icon');
if (icon) icon.style.display = 'block';
// set error viewing level
let imgSrc = '/src/health/images/exclamation-warn.svg';
let imgSrc = '/src/health/images/exclamation-warn.png';
for (const [k, v] of Object.entries(this.activeErrors)) {
if (v.class == 'health-error-label') {
imgSrc = '/src/health/images/exclamation.svg';
imgSrc = '/src/health/images/exclamation-error.png';
}
};
$('#error-svg').attr('src', imgSrc);
Expand Down
Binary file added src/icons/images/signal-bad.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 0 additions & 1 deletion src/icons/images/signal-bad.svg

This file was deleted.

Binary file added src/icons/images/signal-good.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 0 additions & 1 deletion src/icons/images/signal-good.svg

This file was deleted.

Binary file added src/icons/images/signal-poor.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 0 additions & 1 deletion src/icons/images/signal-poor.svg

This file was deleted.

Binary file added src/icons/images/signal-weak.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 0 additions & 1 deletion src/icons/images/signal-weak.svg

This file was deleted.

0 comments on commit e7aa585

Please sign in to comment.