Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transport/StreamFactory.cs enforces Enhanced Key Usage #446

Closed
tomk3003 opened this issue Sep 7, 2017 · 5 comments
Closed

Transport/StreamFactory.cs enforces Enhanced Key Usage #446

tomk3003 opened this issue Sep 7, 2017 · 5 comments

Comments

@tomk3003
Copy link

tomk3003 commented Sep 7, 2017

The X.509 RFC 5280 states that Enhanced Key Usage has to be acknowledged if it is present in the public certificate. When no such key exists in the certificate issued by the server during session creation, a quickfixn client will refuse the certicate with "Remote certificate is not intended for server authentication".

This enforcement should at least be configurable. E.g. it prevents TLS connections to Bloomberg without disabling server authentication alltogether with SSLValidateCertificates=N.

I could implement that, if it is desirable.

@neilejgreen
Copy link

This might be related #264.

@gbirchmeier
Copy link
Member

@tomk3003 Can you please elaborate on that second sentence more?

I think you're saying: "When no such key exists.." the client is erroring out because it thinks that the key should be there (but it's actually optional). Is that a correct interpretation?

If I'm understanding it correctly, then I would gladly accept a PR for it.

@gbirchmeier
Copy link
Member

Is this related to #568?

@tomk3003
Copy link
Author

after reading #264 again I think this is a duplicate. I don't think I'll have the time to do a PR now. I would have had in 2017.

@gbirchmeier
Copy link
Member

That's understandable. :)

And like #264, I think I'm going to defer to what @brobits said on that one: We're not going to work on this, but we will gladly accept a PR if someone wants to do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants