Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Setting/Flag to Revert Scaffolding CSS to PascalCase #365

Open
bstaruk opened this issue Apr 13, 2018 · 0 comments
Open
Assignees

Comments

@bstaruk
Copy link
Contributor

bstaruk commented Apr 13, 2018

We recently switched FC from .PascalCase to .traditional-case selectors (#346).

There is no issue with this change itself, but it's made upgrading some older projects from older version of FC just about impossible -- at least without having to involve back-end developers with changing their CSS class names on their end too.

The solution we've agreed on as a team is to create a setting somewhere in FC that reverts our scaffolding back to PascalCase. There is no need to involve the base elements in this change, because it's intended for folks who are using old versions of FC, so they wouldn't be touching the base elements as part of their upgrade plan (they'd just be bringing over the new build system and dependencies).

Approach

  1. Add a setting in fc-config.js called pascalStyles (or something similar, I am open to suggestions) that is defaulted to false.

  2. Build logic into the scaffolding system that uses the old PascalCase naming convention if that setting is flipped to true, but otherwise operate normally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant