Call cleanup in the finally of each method response instead of abort #1118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@srikrsna-buf @timostamm please let me know if there's anything you need from me for reviewing this! |
lourd
force-pushed
the
fix/always-cleanup
branch
from
2e32fb8
to
6636486
Compare
Signed-off-by: Louis DeScioli <louis.descioli@gmail.com>
lourd
force-pushed
the
fix/always-cleanup
branch
from
6636486
to
3395fcf
Compare
|
Closing this, #1117 will be addressed in v2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1117, avoids user code from having to check the given abort signal to determine if an abort was a true abort or not, and avoids the small overhead of having to execute all abort event handlers.