Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test files included in shipped package of connect-node #1182

Closed
lourd opened this issue Aug 22, 2024 · 2 comments
Closed

Test files included in shipped package of connect-node #1182

lourd opened this issue Aug 22, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@lourd
Copy link

lourd commented Aug 22, 2024

Describe the bug

The test suites for connect-node are being shipped. It would be nice if they weren't. They're quite small, but it's still a waste of bandwidth and storage.

To Reproduce

You can see the test files here on unpkg. They're even duplicated -- they're shipped in both the esm and cjs directories

The testdata directory probably isn't needed either.

@lourd lourd added the bug Something isn't working label Aug 22, 2024
@smaye81
Copy link
Member

smaye81 commented Aug 22, 2024

Thanks for creating. This has actually been fixed in #1112, but it hasn't been released yet. So versions after v1.4.0 should have the correct distribution. Sorry for any inconvenience.

@lourd
Copy link
Author

lourd commented Aug 22, 2024

Oh nice, that's great! Thanks for already doing the work :)

@lourd lourd closed this as completed Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants