Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify our exports with arethetypeswrong #801

Closed
timostamm opened this issue Aug 31, 2023 · 3 comments
Closed

Verify our exports with arethetypeswrong #801

timostamm opened this issue Aug 31, 2023 · 3 comments
Labels
cleanup Cleanup tasks

Comments

@timostamm
Copy link
Member

https://github.com/arethetypeswrong/arethetypeswrong.github.io has been available as a CLI for some time.

Same as bufbuild/protobuf-es#456, we should use it to verify our exports. We need to pick up the work started in bufbuild/protobuf-es#536.

We still populate the main property in our package.json files, which is necessary for Webpack < 5.x (see #167). We should verify whether it is still necessary.

@timostamm timostamm added enhancement New feature or request cleanup Cleanup tasks labels Aug 31, 2023
@srikrsna-buf
Copy link
Member

I tried to do this for knit. The latest unreleased version passes the online test without any problems. It also has sub exports similar to the connect package. Could be useful to take a look.

@timostamm timostamm removed the enhancement New feature or request label Sep 5, 2023
@timostamm
Copy link
Member Author

I tried to do this for knit. The latest unreleased version passes the online test without any problems. It also has sub exports similar to the connect package.

Yes, it's not a big lift to fix reported issues, but I think it's important to understand any issues we fix and nail down a pattern for exports that we can apply to all repositories. The attw CLI then allows us to guard against regressions in CI - but that's only helpful if we have confidence in what issues attw detects and to which ones it is blind.

@smaye81
Copy link
Member

smaye81 commented Sep 28, 2023

Fixed by #838

@smaye81 smaye81 closed this as completed Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Cleanup tasks
Projects
None yet
Development

No branches or pull requests

3 participants