Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adhere to gRPC error code statuses #122

Closed
joshcarp opened this issue Jul 7, 2023 · 2 comments · Fixed by #144
Closed

Adhere to gRPC error code statuses #122

joshcarp opened this issue Jul 7, 2023 · 2 comments · Fixed by #144

Comments

@joshcarp
Copy link
Contributor

joshcarp commented Jul 7, 2023

open-telemetry/opentelemetry-specification#3333 introduced a breaking change to the OpenTelemetry semantic conventions for gRPC so this should be implemented
@joshcarp
Copy link
Contributor Author

joshcarp commented Jul 7, 2023

gRPC Status Code SpanKind.SERVER Span Status SpanKind.CLIENT Span Status
OK unset unset
CANCELLED unset Error
UNKNOWN Error Error
INVALID_ARGUMENT unset Error
DEADLINE_EXCEEDED Error Error
NOT_FOUND unset Error
ALREADY_EXISTS unset Error
PERMISSION_DENIED unset Error
RESOURCE_EXHAUSTED unset Error
FAILED_PRECONDITION unset Error
ABORTED unset Error
OUT_OF_RANGE unset Error
UNIMPLEMENTED Error Error
INTERNAL Error Error
UNAVAILABLE Error Error
DATA_LOSS Error Error
UNAUTHENTICATED unset Error

@dragon3 dragon3 mentioned this issue Nov 3, 2023
Merged
@dragon3
Copy link
Contributor

dragon3 commented Nov 3, 2023

Hi,
I've just created a pull request to fix this issue 👉 #144

Please take a look when you get a chance 🙏
Thank you!

@jhump jhump mentioned this issue Dec 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Align gRPC server status code to span status code dragon3/otelconnect-go
2 participants
@dragon3 @joshcarp