Skip to content
This repository has been archived by the owner on May 28, 2021. It is now read-only.

[all] Quorum strangeness #1281

Closed
LayneHaber opened this issue Jul 1, 2020 · 0 comments · Fixed by #1284
Closed

[all] Quorum strangeness #1281

LayneHaber opened this issue Jul 1, 2020 · 0 comments · Fixed by #1284
Assignees
Labels
Bug Something isn't working p1 Bugs/Tests/Blockers Bugs that break things but no loss of funds + Test improvements + PRIORITY blockers for customers.

Comments

@LayneHaber
Copy link
Contributor

Describe the bug
Very strange error reported in #1275 -- working theory is:

  1. JsonRpcProviders are created with a URL and do not specify a network. The provider will then allow for any network, and autodetect/update if there is a network change
  2. A network change is detected (not sure why that is, but it's key to my theory)
  3. There is no provider for that network, so ethers uses its FallbackProvider and resets the emitted blocks tag to -2 and tries to begin polling
  4. All providers fail to get the block number (some seemed to be getting rate limited), and the provider throws the quorum error.

To test this theory (and hopefully narrow down if 3 is relevant or the root cause of it), we should specify networks when creating JsonRpcProviders to force them to throw instead of sync if a network change is detected.

To Reproduce
Not sure, have to ask XUD.

@LayneHaber LayneHaber added the Needs Triage Needs to be looked at and prioritized. label Jul 1, 2020
@LayneHaber LayneHaber added Bug Something isn't working p1 Bugs/Tests/Blockers Bugs that break things but no loss of funds + Test improvements + PRIORITY blockers for customers. and removed Needs Triage Needs to be looked at and prioritized. labels Jul 2, 2020
@LayneHaber LayneHaber self-assigned this Jul 2, 2020
@LayneHaber LayneHaber mentioned this issue Jul 2, 2020
5 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Something isn't working p1 Bugs/Tests/Blockers Bugs that break things but no loss of funds + Test improvements + PRIORITY blockers for customers.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant