Skip to content
This repository has been archived by the owner on May 28, 2021. It is now read-only.

pruneExpiredApps fails #1330

Closed
ghost opened this issue Jul 23, 2020 · 4 comments · Fixed by #1338
Closed

pruneExpiredApps fails #1330

ghost opened this issue Jul 23, 2020 · 4 comments · Fixed by #1338
Labels
Bug Something isn't working p2: User Shipping Needs Important (but minimal) refactors/enhancements/fixes needed for customers
Milestone

Comments

@ghost
Copy link

ghost commented Jul 23, 2020

Describe the bug
* (HEAD detached at 5c378ae4d)

2020-07-23T21:02:20.789Z [TransferService] Start pruneExpiredApps for channel 0x98aa7B68CaC15a08Be1E4C786d6b8e2a53a06685 on chainId 4
2020-07-23T21:02:21.212Z [Main] Unhandled Promise Rejection: TypeError: Cannot read property 'filter' of undefined
    at TransferService.eval (webpack:///./src/transfer/transfer.service.ts?:88:58)
    at Generator.next (<anonymous>)
    at fulfilled (webpack:///./src/transfer/transfer.service.ts?:14:58)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
@ghost ghost added the Needs Triage Needs to be looked at and prioritized. label Jul 23, 2020
@kilrau
Copy link

kilrau commented Jul 23, 2020

Original PR: #1315

@ArjunBhuptani
Copy link
Member

As a note for whoever tackles this: there's nothing actually going wrong here, we just need to not attempt to prune if there are no apps.

@ArjunBhuptani ArjunBhuptani added Bug Something isn't working Duplicate Duplicate issue p2: User Shipping Needs Important (but minimal) refactors/enhancements/fixes needed for customers and removed Needs Triage Needs to be looked at and prioritized. Duplicate Duplicate issue labels Jul 24, 2020
@kilrau
Copy link

kilrau commented Jul 24, 2020

Interesting, but I am pretty sure @erkarl had a pending htlc up there when indra threw the above. Can you add some client logs to confirm? @erkarl

@ghost
Copy link
Author

ghost commented Jul 24, 2020

Interesting, but I am pretty sure @erkarl hat a pending htlc up there when indra threw above. Can you add some client logs to confirm? @erkarl

Yup, that was the case on mainnet - got 1 conditional transfer that has expired, but looks like the app was never uninstalled.

@ArjunBhuptani ArjunBhuptani added this to the 9.0.1 milestone Jul 25, 2020
@rhlsthrm rhlsthrm linked a pull request Jul 27, 2020 that will close this issue
5 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Something isn't working p2: User Shipping Needs Important (but minimal) refactors/enhancements/fixes needed for customers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants