Skip to content
This repository has been archived by the owner on May 28, 2021. It is now read-only.

[cf-core] Validation Middleware #959

Closed
LayneHaber opened this issue Apr 3, 2020 · 0 comments · Fixed by #962
Closed

[cf-core] Validation Middleware #959

LayneHaber opened this issue Apr 3, 2020 · 0 comments · Fixed by #962
Assignees
Labels
Enhancement New feature or request p0 CRITICAL CRITICAL bugfixes and security problems leading to potential loss of funds

Comments

@LayneHaber
Copy link
Contributor

Description
Currently, there is no way to inject validation into the node. This is a problem, particularly for uninstall, when users may be able to prematurely uninstall apps. Client and node should be able to inject middleware to be executed prior to state transitions within the lower level frameworks.

Solution
Add an injectMiddleware function to cf-core that will be run prior to the state transitions in each protocol in response to an OP_VALIDATE call.

If the callback passed in errors, the protocol should fail before updating the store.

@LayneHaber LayneHaber added the p1 Bugs/Tests/Blockers Bugs that break things but no loss of funds + Test improvements + PRIORITY blockers for customers. label Apr 3, 2020
@LayneHaber LayneHaber self-assigned this Apr 3, 2020
@LayneHaber LayneHaber added Enhancement New feature or request p0 CRITICAL CRITICAL bugfixes and security problems leading to potential loss of funds and removed p1 Bugs/Tests/Blockers Bugs that break things but no loss of funds + Test improvements + PRIORITY blockers for customers. labels Apr 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Enhancement New feature or request p0 CRITICAL CRITICAL bugfixes and security problems leading to potential loss of funds
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant