fix(wash): windows path to target

Verbatim paths on Windows are not well supported,
e.g. "\\\\?\\C:\\Users..." while technically valid, causes some fs api's like `exists` to fail errantly.

The fix is to use a third party lib normpath to normalize the path to the wasm
binary.

Related issue: rust-lang/cargo#9770

Signed-off-by: Bailey Hayes <behayes2@gmail.com>
Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>

Author: 2 people

Cargo.lock

@@ -118,6 +118,7 @@ names = { version = "0.14", default-features = false }
 nix = { version = "0.27", default-features = false }
 nkeys = { version = "0.3", default-features = false }
 notify = { version = "6", default-features = false }
+normpath = { version = "1.1" , default-features = false }
 nuid = { version = "0.4", default-features = false }
 oci-distribution = { version = "0.9", default-features = false }
 once_cell = { version = "1", default-features = false }

Cargo.toml

@@ -54,6 +54,7 @@ heck = { workspace = true, optional = true }
 ignore = { workspace = true, optional = true }
 indicatif = { workspace = true, optional = true }
 nkeys = { workspace = true }
+normpath = { workspace = true }
 oci-distribution = { workspace = true, features = ["rustls-tls"] }
 path-absolutize = { workspace = true, features = [
     "once_cell_cache",

crates/wash-lib/Cargo.toml

@@ -9,6 +9,7 @@ use std::{
 };
 
 use anyhow::{anyhow, bail, Context, Result};
+use normpath::PathExt;
 use tracing::{debug, info, warn};
 use wasm_encoder::{Encode, Section};
 use wit_bindgen_core::Files;
@@ -240,10 +241,7 @@ fn build_rust_actor(
     // Change directory into the project directory
     std::env::set_current_dir(&common_config.path)?;
 
-    let metadata = cargo_metadata::MetadataCommand::new().exec()?;
-    let target_path = metadata.target_directory.as_path();
-    let build_target = rust_config.build_target(&actor_config.wasm_target);
-
+    let build_target: &str = rust_config.build_target(&actor_config.wasm_target);
     let result = command
         .args(["build", "--release", "--target", build_target])
         .status()
@@ -265,23 +263,27 @@ fn build_rust_actor(
         .as_ref()
         .unwrap_or(&common_config.name);
 
-    let wasm_file = PathBuf::from(format!(
-        "{}/{}/release/{}.wasm",
-        rust_config
-            .target_path
-            .clone()
-            .unwrap_or_else(|| PathBuf::from(target_path))
-            .to_string_lossy(),
-        build_target,
-        wasm_bin_name,
-    ));
-
-    if !wasm_file.exists() {
-        bail!(
-            "Could not find compiled wasm file, please ensure {} exists",
-            wasm_file.display()
-        );
-    }
+    // NOTE: Windows paths are tricky.
+    // We're using a third-party library normpath to ensure that the paths are normalized.
+    // Once out of nightly, we should be able to use std::path::absolute
+    // https://github.com/rust-lang/rust/pull/91673
+    let metadata = cargo_metadata::MetadataCommand::new().exec()?;
+    let target_path = rust_config
+        .target_path
+        .clone()
+        .unwrap_or_else(|| PathBuf::from(metadata.target_directory.as_std_path()));
+    let mut wasm_path_buf = PathBuf::from(target_path);
+    wasm_path_buf.push(build_target);
+    wasm_path_buf.push("release");
+    wasm_path_buf.push(format!("{}.wasm", wasm_bin_name));
+
+    // Ensure the file exists, normalize uses the fs and file must exist
+    let wasm_file = match wasm_path_buf.normalize() {
+        Ok(p) => p,
+        Err(e) => bail!(
+            "Could not find compiled wasm file, please ensure {:?} exists. Error: {:?}", wasm_path_buf, e
+        ),
+    };
 
     // move the file out into the build/ folder for parity with tinygo and convienience for users.
     let copied_wasm_file = PathBuf::from(format!("build/{}.wasm", wasm_bin_name));