Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Optional) Method in Checkpoint actor clear past checkpoints #204

Closed
Tracked by #211
aakoshh opened this issue Sep 7, 2023 · 2 comments
Closed
Tracked by #211

(Optional) Method in Checkpoint actor clear past checkpoints #204

aakoshh opened this issue Sep 7, 2023 · 2 comments
Assignees

Comments

@aakoshh
Copy link
Contributor

aakoshh commented Sep 7, 2023

At some point, if we see that the checkpoint has been registered in the parent, we may want to clear out past checkpoints to free up space in our ledger.

@aakoshh aakoshh changed the title Method in Checkpoint actor clear past checkpoints (Optional) Method in Checkpoint actor clear past checkpoints Sep 7, 2023
@dnkolegov
Copy link
Contributor

dnkolegov commented Sep 21, 2023

@aakoshh Should we also have a variable H in the actor state, which means all checkpoints with height <= H have been committed and may be removed? And no one else can add a signature for that checkpoint.

What functions Fendremint does need?

removeCheckpoints(uint256 lastCheckpointHeight) - remove all checkpoints with height h <= lastCheckpointHeight
removeCheckpoint(uint256 checkpointHeight) - removethe checkpoints with height checkpointHeight
removeCheckpoints(uint256[] checkpointHeights) - removethe checkpoints with heights from checkpointHeights

@dnkolegov dnkolegov self-assigned this Sep 22, 2023
@dnkolegov
Copy link
Contributor

dnkolegov commented Sep 22, 2023

Implemented - consensus-shipyard/ipc-solidity-actors#207

@jsoares jsoares transferred this issue from consensus-shipyard/fendermint Dec 19, 2023
@jsoares jsoares closed this as not planned Won't fix, can't repro, duplicate, stale Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants