Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Optional) Method in Checkpoint actor to check for quorum and emit signature #306

Closed
Tracked by #211
aakoshh opened this issue Sep 7, 2023 · 3 comments
Closed
Tracked by #211
Assignees

Comments

@aakoshh
Copy link
Contributor

aakoshh commented Sep 7, 2023

This method is an optional way for timing when the quorum even is emitted. The thinking is that we want to make the quorum as big as possible, so we don't want to emit the event as soon as quorum is reached and freeze it there. My first thought was maybe to call a method at the end of the block, although that's not a big delay.

But as explained in #205 it makes even more sense to keep accumulating signatures and let the relayers decide when they send it, because they can modify the list of signatures anyway, it's malleable. We can offer more rewards for relaying with more signatures.

@dnkolegov
Copy link
Contributor

In consensus-shipyard/ipc-solidity-actors#202 the following is implemented:
QuorumWeightUpdated event is emitted every time a new signature is added after reaching the threshold weight.

@dnkolegov dnkolegov self-assigned this Sep 22, 2023
@dnkolegov
Copy link
Contributor

@aakoshh may we close it? Is it implemented as intended or not?

@aakoshh
Copy link
Contributor Author

aakoshh commented Sep 27, 2023

Yes, I think we can close it.

@aakoshh aakoshh closed this as completed Sep 27, 2023
@jsoares jsoares transferred this issue from consensus-shipyard/fendermint Dec 19, 2023
@jsoares jsoares closed this as not planned Won't fix, can't repro, duplicate, stale Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants