You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Have you reproduced the bug with the latest dev version?
Yes
Version
dev
Custom code
No
OS platform and distribution
No response
Describe the issue
Trying to import a wallet without arguments only complains about the missing wallet type:
ubuntu@ip-172-26-4-182:~/ipc$ ./bin/ipc-cli wallet import
error: the following required arguments were not provided:
--wallet-type <WALLET_TYPE>
Usage: ipc-cli wallet import --wallet-type <WALLET_TYPE>
#[arg(long, short, help = "The type of the wallet, i.e. fvm, evm")]
pubwallet_type:String,
#[arg(long, short, help = "Path of key info file for the key to import")]
pubpath:Option<String>,
#[arg(
long,
short,
help = "The evm private key to import if path is not specified"
)]
pubprivate_key:Option<String>,
}
.
So they appear when --help is added but not by default. They are indeed optional as it stands but we should either default to one or provide appropriate guidance in the usage/error message.
Repro steps
See above.
Relevant log output
No response
The text was updated successfully, but these errors were encountered:
Issue type
Bug
Have you reproduced the bug with the latest dev version?
Yes
Version
dev
Custom code
No
OS platform and distribution
No response
Describe the issue
Trying to import a wallet without arguments only complains about the missing wallet type:
Adding the wallet type errors
This is expected as we're not providing the key but we're also not guiding the user as to how to do it.
This seems to stem from the command accepting either a path to the keyfile or a string, both being set as optional in
ipc/ipc/cli/src/commands/wallet/import.rs
Lines 60 to 71 in 0148c7b
So they appear when --help is added but not by default. They are indeed optional as it stands but we should either default to one or provide appropriate guidance in the usage/error message.
Repro steps
See above.
Relevant log output
No response
The text was updated successfully, but these errors were encountered: