Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use &self instead of mut self when provider sends txs. #383

Closed
adlrocha opened this issue Sep 14, 2023 · 0 comments
Closed

Use &self instead of mut self when provider sends txs. #383

adlrocha opened this issue Sep 14, 2023 · 0 comments
Assignees
Labels

Comments

@adlrocha
Copy link
Contributor

Related to #400 and tracked here.

Making this mut will lead to methods that require sending txn to use mut self when using the provider, which might force owner of this struct to use mut self, i.e. fendermint top down provider might encounter this issue. If mut is not necessary, we can just stick with self, else callers might have to use RWLock for this.

@jsoares jsoares transferred this issue from consensus-shipyard/ipc-libs Dec 19, 2023
@jsoares jsoares added the s:ipc label Dec 19, 2023
@jsoares jsoares closed this as not planned Won't fix, can't repro, duplicate, stale Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants