Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPLD Resolver: Integration Test #464

Closed
aakoshh opened this issue Feb 24, 2023 · 1 comment · Fixed by consensus-shipyard/ipc-libs#64
Closed

IPLD Resolver: Integration Test #464

aakoshh opened this issue Feb 24, 2023 · 1 comment · Fixed by consensus-shipyard/ipc-libs#64
Labels

Comments

@aakoshh
Copy link
Contributor

aakoshh commented Feb 24, 2023

Part of #475

Start an in-memory cluster of #465 and run tests on them to show that they discover each other, learn the membership table, and are able to resolve CIDs. Run scenarios for late joiners to see how Gossipsub behaves.

@aakoshh
Copy link
Contributor Author

aakoshh commented Mar 2, 2023

I found these tests for reference in libp2p:

They all do a different combination:

  • gossipsub: uses MemoryTransport with Swarm::without_executor, manually polling all created Swarms from the test
  • ping: uses tcp::async_io::Transport with Swarm::with_async_std_executor, running the created Swarms in their own Task
  • transport: uses MemoryTransport with Swarm::with_async_std_executor

In my case, the Service::new sets up its own libp2p::tcp::tokio::Transport and Swarm::with_tokio_executor, then does the polling in Service::run. I suppose I can factor out transport creation to try to use MemoryTransport, but breaking out run would be awkward, so out of these the 3rd example seems to be where we want to be.

@jsoares jsoares transferred this issue from consensus-shipyard/ipc-libs Dec 19, 2023
@jsoares jsoares added the s:ipc label Dec 19, 2023
@jsoares jsoares closed this as not planned Won't fix, can't repro, duplicate, stale Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants