Skip to content
This repository has been archived by the owner on Dec 20, 2023. It is now read-only.

Assign different ChainIDs to the different subnets #178

Closed
Tracked by #109
adlrocha opened this issue May 16, 2023 · 2 comments · Fixed by #187
Closed
Tracked by #109

Assign different ChainIDs to the different subnets #178

adlrocha opened this issue May 16, 2023 · 2 comments · Fixed by #187
Labels

Comments

@adlrocha
Copy link
Contributor

We currently use the same ChainID for all subnets in IPC:

const Eip155ChainId = 31415926
. While we have a different NetworkName according to the SubnetID of the subnet, there is no way to differentiate the different subnets by ChainID what could open the door to potential replay attacks.

In order to overcome this issue, we should make the ChainID for a subnet inferable from its SubnetID. We could use a similar approach to the one used by FRC42 to deterministically get a method number integer from a method name string.

@adlrocha
Copy link
Contributor Author

adlrocha commented May 22, 2023

@adlrocha
Copy link
Contributor Author

Rust implementation in Fendermint: consensus-shipyard/fendermint#115

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant