Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(transaction-update): replace ethereumjs-util with @ethereumjs/util #720

Merged
merged 2 commits into from
May 17, 2024

Conversation

legobeat
Copy link
Contributor

Description

ethereumjs-util is deprecated and maintained as @ethereumjs/util as of v8. metamask-institutional is already using the newer version, except in one place.

The only outstanding usage has been migrated to @ethereumjs/util and legacy ethereumjs-util has been removed.

Motivation and Context

How Has This Been Tested?

Not at all.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@legobeat legobeat marked this pull request as ready for review May 15, 2024 05:46
@zone-live zone-live merged commit 136bb72 into consensys-vertical-apps:main May 17, 2024
3 checks passed
@zone-live zone-live mentioned this pull request May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants