Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added export state log feature #841

Merged
merged 5 commits into from
Oct 11, 2024

Conversation

albertolive
Copy link
Contributor

@albertolive albertolive commented Oct 10, 2024

Description

  1. Implemented comprehensive API request logging across the project
    • Added to CustodyController, CustodyKeyring, MMISDK, and various API clients
    • Logs include method, endpoint, success status, timestamps, and error messages
  2. Introduced IApiCallLogEntry interface to types package for standardized log entries
  3. Added API_REQUEST_LOG_EVENT constant for consistent event emission
  4. Implemented log storage with a 500-entry limit in CustodyController
  5. Added export state log feature in CustodyController

Motivation and Context

https://consensyssoftware.atlassian.net/browse/MMI-5436

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

zone-live
zone-live previously approved these changes Oct 11, 2024
Copy link
Collaborator

@zone-live zone-live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work Albert! 💪🏼

@albertolive albertolive merged commit 28e6083 into main Oct 11, 2024
5 checks passed
@albertolive albertolive deleted the MMI-5436-export-state-log-feature branch October 11, 2024 13:56
@zone-live zone-live mentioned this pull request Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants