Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: reduced redundant constraints in range check #148

Merged
merged 6 commits into from
Oct 13, 2021
Merged

perf: reduced redundant constraints in range check #148

merged 6 commits into from
Oct 13, 2021

Conversation

gbotrel
Copy link
Collaborator

@gbotrel gbotrel commented Oct 12, 2021

AssertIsLessOrEqual creates ~15% less constraints (variable < variable) and ~50% less constraints (variable < constraint).

Following ZCash specs -- and noticing the "in place boolean constraints".

@gbotrel gbotrel added this to the v0.6.0 milestone Oct 12, 2021
@gbotrel gbotrel changed the base branch from master to develop October 12, 2021 21:09
@gbotrel gbotrel merged commit 5ab2ce7 into develop Oct 13, 2021
@gbotrel gbotrel deleted the perf-range-check branch October 13, 2021 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomasPiellard ThomasPiellard Awaiting requested review from ThomasPiellard

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.6.0
Development

Successfully merging this pull request may close these issues.
1 participant
@gbotrel