Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean std/twistededwards #156

Merged
merged 5 commits into from
Oct 27, 2021
Merged

clean std/twistededwards #156

merged 5 commits into from
Oct 27, 2021

Conversation

yelhousni
Copy link
Contributor

  • cleans std/twistededwards to match gnark-crypto (A is back!)
  • fixes a bug in scalarmul test (always passes regardless of the witness)
  • adds bench to get constraints numbers

gbotrel
gbotrel reviewed Oct 27, 2021
View reviewed changes
std/algebra/twistededwards/point_test.go Outdated
// ------------------------------------------------------------
// benches

var ccsBench frontend.CompiledConstraintSystem
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need a more consistant way to track number of constraints per "gadget" in std. Similar stuff than gnark/circuitsstats_test.go

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but maybe for the next release once we give enough love to all std/. For now, I can get rid of the bench.

@gbotrel gbotrel merged commit 0a0d5af into develop Oct 27, 2021
@gbotrel gbotrel deleted the std/twistedEdwards branch October 27, 2021 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbotrel gbotrel gbotrel left review comments

@ThomasPiellard ThomasPiellard Awaiting requested review from ThomasPiellard

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yelhousni @gbotrel