-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: frontend.Variable is now an interface, simplifies witness assignment and constant usage #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivokub
requested changes
Nov 17, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in general. Added a few type descriptions and fixed some assignments.
Co-authored-by: Ivo Kubjas <tsimmm@gmail.com>
Co-authored-by: Ivo Kubjas <tsimmm@gmail.com>
This was referenced Nov 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses few feedbacks.
It unfortunately introduces some breaking changes in the API.
circuit.Define(curveID, api)
is nowcircuit.Define(api)
frontend.Variable
is now an interface. Consequences to that is;api.Constant(x)
is removed, doingmyVariable = 2
instead ofmyVariable = api.Constant(2)
will behaves as expected.Assign()
method is removed, one can now simply assign witness value like sowitness := &circuit{A: value}
api.IsConstant(Variable) -> bool
andapi.ConstantValue(Variable) -> big.Int
which enables circuit developers to write specific version of their circuit depending on if a variable is known at compile time. Note: the big.Int test engine will return true to all values, and may not test all code path against the constraint solver.Unsuspected side effect to this PR;
frontend.Compile
is now ~40% faster for Groth16.