-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add subtests to test.Assert #191
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbotrel
requested changes
Dec 7, 2021
ivokub
force-pushed
the
assert-subtests
branch
2 times, most recently
from
December 9, 2021 10:12
5b657f9
to
0ade5c1
Compare
I went over again over the different range loops and initialized the iteration-local variables everywhere they were used locally. |
ivokub
force-pushed
the
assert-subtests
branch
2 times, most recently
from
December 9, 2021 12:06
21f3ece
to
0a170e7
Compare
assert.ProverSucceeded already calls assert.Fuzz.
ivokub
force-pushed
the
assert-subtests
branch
from
December 22, 2021 14:46
0a170e7
to
6a0900c
Compare
gbotrel
approved these changes
Dec 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added method
Run(fn func(assert *test.Assert), descs ...string)
to Assert type. This is similar to theRun
method in Go's standard testing package to allow running subtests. Refactored tests in places to use subtests.Removed explicit
Fuzz
call in integration tests as Fuzz is already called inAssert.ProverSucceeded
.An potential added benefit of using subtests is better coverage with race detector and enabling running subtests in parallel. I didn't implement it now though as Assert uses unsynchronized cache for compiled circuits.