Reduce constant values by the modulus #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivokub
force-pushed
the
fix/constant-mod-reduction
branch
from
1572061 to
a64b624
Compare
ivokub
force-pushed
the
fix/constant-mod-reduction
branch
from
a64b624 to
b3b6ae2
Compare
|
I added modulo reduction to cs.reduce method -- in constructed circuits it results in 10% performance loss and 20% more allocations. However, it is anticipated that we can get it back with generics, when we can use |
ThomasPiellard
approved these changes
Dec 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The internal method which computes the constants in the constraint system didn't reduce the integers by the modulus.
Closes #203. Needs to be ported on top of #200.