Group functional options in frontend, backend and test #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbotrel
approved these changes
Jan 12, 2022
ivokub
force-pushed
the
cleanup-231-group-options
branch
from
2f8d00c to
bfd9393
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the framework of functional options as described in https://sagikazarmark.hu/blog/functional-options-on-steroids/ and https://dave.cheney.net/2014/10/17/functional-options-for-friendly-apis with slight changes. Namely, didn't rename a few methods to
Set/With...pattern and didn't defineOptionto beinterface{ apply(*config) error}to be backwards compatible.Closes #231