Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: r1cs solver 40% faster by avoiding redudnant check #248

Merged
merged 7 commits into from
Feb 3, 2022
Merged

perf: r1cs solver 40% faster by avoiding redudnant check #248

merged 7 commits into from
Feb 3, 2022

Conversation

gbotrel
Copy link
Collaborator

@gbotrel gbotrel commented Feb 2, 2022 •
edited
Loading

  • test: added r1cs solve benchmark
  • perf: r1cs solver 40% faster by avoiding redudnant check
  • fix: r1cs solver was incorrectly doing a multiplication by a coeff instead of a div. It didn't show since coeff value at this stage was -1 or 1 (== same result for div).
name      old time/op    new time/op    delta
Solve-10    61.2ms ± 2%    37.3ms ± 2%  -39.07%  (p=0.333 n=2+2)

@gbotrel gbotrel added the perf label Feb 2, 2022
@gbotrel gbotrel added this to the v0.7.0 milestone Feb 2, 2022
@gbotrel gbotrel marked this pull request as draft February 2, 2022 17:17
@gbotrel gbotrel marked this pull request as ready for review February 2, 2022 19:22
@gbotrel gbotrel merged commit 912fe09 into develop Feb 3, 2022
@gbotrel gbotrel deleted the perf-ccs-solver branch February 3, 2022 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomasPiellard ThomasPiellard ThomasPiellard approved these changes

Assignees
No one assigned
Labels
perf
Projects
None yet
Milestone
v0.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@gbotrel @ThomasPiellard