Plonk+Groth16 adapted to updated FFT #253

ThomasPiellard · 2022-02-09T11:43:29Z

Plonk and Groth16 uses latest FFT from gnark-crypto (see PR 145 of gnark-crypto).

Internal changes:

The permutation polynomial in PLONK uses an extra challenge beta
The quotient in Groth16 and Plonk has been modified according to the coset on which it is evaluated

It fixes #239 .

internal/backend/bls12-377/plonk/prove.go

internal/backend/bw6-761/cs/to_delete.go

gbotrel · 2022-02-13T17:55:38Z

looks good, couple of cosmetic changes 👍 . running mathfmt everywhere did pollute a bit the PR though, lots of files affected :)

ThomasPiellard added 12 commits February 4, 2022 14:38

feat: groth16 prover adapted to new fft OK

936bd06

feat: polynomial --> []frElement

208235e

fix: fixed plonk up to permutation polynomial

0c69bf1

fix: correct up to quotient

a336a73

fix: linearized polynomial OK

5c04c28

fix: missing beta in linearized polynomial

7939340

fix: verifier obtains correct quotient

1890b52

fix: fixed verifier

c85e67c

style: removed debug comments

cd0abd9

feat: code gen for plonk

50459e8

feat: udpate gnark-crypto

6926710

feat(plonk): beta is dervied using Fiat Shamir

e8cdcda

ThomasPiellard marked this pull request as ready for review February 9, 2022 14:22

ThomasPiellard requested a review from gbotrel February 10, 2022 08:14

gbotrel requested changes Feb 13, 2022

View reviewed changes

ThomasPiellard and others added 3 commits February 14, 2022 11:27

fix: restored commented code blinding polynomial

f541b19

fix: resolve comments

7c12817

build: updatd to latezst gnarkcrypto

5e875a4

gbotrel merged commit 4b6ccfd into develop Feb 14, 2022

gbotrel deleted the feat/fft_cosets branch February 14, 2022 16:29

Provide feedback