-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
frontend/
refactor: separate responsabilities to Builder
, Compiler
and API
interfaces
#271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on #270 . (see description for hint changes).
** API Breaking change **
Fixes #245 ; using options 4. -->
frontend.Compile
changed from :frontend.Compile(curveID ecc.ID, backendID backend.ID, circuit Circuit, opts ...CompileOption)
tofrontend.Compile(curveID ecc.ID, newCompiler frontend.NewCompiler, circuit Circuit, opts ...CompileOption)
** Internal changes **
frontend.Compiler
interface, which exposes useful operations to gadget developers that do not fit infrontend.API
. For example, to create astd/math/bits
package, one needs to have access toMarkBoolean
andIsBoolean
apis from the constraint system compiler. Naming wise, end-users only see the termCompiler
. (not Builders, etc).compiled.Variable
is no more. It used to encapsulate acompiled.LinearExpression
and aIsBoolean bool
value. Replaced withcompiled.LinearExpression
,IsBoolean
is managed through a map.frontend.WithCapacity
was broken and compile options were not passed through constraint systems compilersIsConstant
removed in favor ofConstantValue
(reduces useless big.Int allocations)