simplify post compile phase: shifting wire id is not needed 🙈 #280
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🙈 --> we used to do a weird dance in a post-compile phase, where we would loop through all constraints, logs, debuginfo, hints, and offset the ids of the wires. This was unnecessary complicated; new version just count the number of public and secret variables before calling
Define
, so, the r1cs builder and plonk builder both know the offset to add to new internal wires... voila.