Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean: remove PairingContext and Extension objects from api calls in std/.../pairing #286

Merged
merged 3 commits into from
Mar 22, 2022
Merged

clean: remove PairingContext and Extension objects from api calls in std/.../pairing #286

merged 3 commits into from
Mar 22, 2022

Conversation

gbotrel
Copy link
Collaborator

@gbotrel gbotrel commented Mar 21, 2022

  • fix: remove unused pairingContext.BTwistCoeff
  • fix: remove unused pairingContext.BTwistCoeff
  • clean: remove PairingContext and Extension objects from api calls in std/../pairing

@gbotrel gbotrel requested a review from yelhousni March 21, 2022 22:31
@gbotrel gbotrel added this to the v0.7.0 milestone Mar 21, 2022
@gbotrel
Copy link
Collaborator Author

gbotrel commented Mar 21, 2022

Pairing and groth16.Verify had PairingContext and Extension objects in all APIs, always initialized to the same values.

Removed them in favor of a package private global var.

yelhousni
yelhousni approved these changes Mar 22, 2022
View reviewed changes
Copy link
Contributor

@yelhousni yelhousni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cleaner, better. LGTM.

@gbotrel gbotrel merged commit a7d6e18 into develop Mar 22, 2022
@gbotrel gbotrel deleted the clean/std/pairing branch March 22, 2022 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yelhousni yelhousni yelhousni approved these changes

Assignees
No one assigned
Labels
cleanup
Projects
None yet
Milestone
v0.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@gbotrel @yelhousni