-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: misspelled ("decsribes" -> "describes") #339
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hey, thanks for the contrib, can you modify the r1cs.go.tmpl file and run go generate ./... on your PR? |
Sorry, I'm new to the project and I didn't realize this file was auto-generated from the template. I will modify as you said. |
gbotrel
added a commit
that referenced
this pull request
Sep 14, 2022
* fix: misspelled ("decsribes" -> "describes") (#339) * fix misspelled ("decsribes" -> "describes") * fix misspelled ("decsribes" -> "describes") from tmpl file and regenerate Co-authored-by: tinywell <tinywell@tinywell.com> * add plonk verifier: support single proof verification * remove unused variable in solidity * build: re-ran go generate * docs: add un-audited warning in plonk solidity * feat: change solidity ver for plonk * feat: factorize serailization test in plonk * feat: added writeRaw for plonk proof * feat: added io.WriterRawTo to plonk.Proof * fix: change loop condition to avoid revert with solc * docs: updated ExportSolidity docs Co-authored-by: tinywell <zfh-zyw@163.com> Co-authored-by: tinywell <tinywell@tinywell.com> Co-authored-by: ryan <lightningli0504@gmail.com>
gbotrel
added a commit
that referenced
this pull request
Sep 15, 2022
* fix: misspelled ("decsribes" -> "describes") (#339) * fix misspelled ("decsribes" -> "describes") * fix misspelled ("decsribes" -> "describes") from tmpl file and regenerate Co-authored-by: tinywell <tinywell@tinywell.com> * Fix Or && Xor Co-authored-by: tinywell <zfh-zyw@163.com> Co-authored-by: tinywell <tinywell@tinywell.com> Co-authored-by: Gautam Botrel <gautam.botrel@gmail.com>
gbotrel
pushed a commit
that referenced
this pull request
Oct 6, 2022
* fix: misspelled ("decsribes" -> "describes") (#339) * fix misspelled ("decsribes" -> "describes") * fix misspelled ("decsribes" -> "describes") from tmpl file and regenerate Co-authored-by: tinywell <tinywell@tinywell.com> * Fix: minor typo (#360) Fix: minor typo * Use shared array for input * Fixes in the template Co-authored-by: tinywell <zfh-zyw@163.com> Co-authored-by: tinywell <tinywell@tinywell.com> Co-authored-by: omahs <73983677+omahs@users.noreply.github.com>
AlexandreBelling
pushed a commit
to AlexandreBelling/gnark
that referenced
this pull request
Nov 24, 2022
* fix: misspelled ("decsribes" -> "describes") (Consensys#339) * fix misspelled ("decsribes" -> "describes") * fix misspelled ("decsribes" -> "describes") from tmpl file and regenerate Co-authored-by: tinywell <tinywell@tinywell.com> * Fix: minor typo (Consensys#360) Fix: minor typo * Use shared array for input * Fixes in the template Co-authored-by: tinywell <zfh-zyw@163.com> Co-authored-by: tinywell <tinywell@tinywell.com> Co-authored-by: omahs <73983677+omahs@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix misspelled word
decsribes
todescribes
in the comment of structR1CS