-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define minimum TF verison #6
Comments
I removed TF 1.x support in the loadMD function. |
Added minimum version 2.5.0 to the description file |
I just checked loadmodel, did you push it? It still says tfsession <- tf$compat$v1$Session() |
The code is up to date. The .pb file used by MD is a TF 1.x format so we are using backwards compatibility implemented in TF 2.x to call 1.x functions (hence tf$compat$v1$...). This code will not work with TF 1.x. There used to be a check of which TF version was present and if 1.x was detected there was a different code to load the model, but since we depend on 2.x for other parts of the code (e.g. data generators) we might as well drop that. So I removed that part of the code. |
With the integration of new tf.data functions we need to define the minimum version of TF that we will support. I also noticed that EfficientNet models trained on 2.5 will not work any longer on 2.3. So we probably want to set TF>2.5. We definitely want to remove TF 1.x support for MegaDetector (load MD model function).
The text was updated successfully, but these errors were encountered: