Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't eagerly close tty fd in read_secure #222

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Don't eagerly close tty fd in read_secure #222

wants to merge 1 commit into from

Conversation

Noratrieb
Copy link

The tcsetattr was failing because the fd was closed in the if statement before, where it was moved out.

i tested locally that this fixes #221

@Noratrieb
Don't eagerly close tty fd in read_secure
0cd6125 
The tcsetattr was failing because the fd was closed in the if statement
before, where it was moved out.
@tamird tamird mentioned this pull request Aug 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

On Unix, read_secure_line doesn't work if stdin isn't a TTY
1 participant
@Noratrieb