Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS minifier upgrade #1114

Open
banago opened this issue Jun 15, 2022 · 1 comment
Open

CSS minifier upgrade #1114

banago opened this issue Jun 15, 2022 · 1 comment

Comments

@banago
Copy link

banago commented Jun 15, 2022

I'm using robo css to minify CSS on my workflow.

Up to PHP 7.4 it works fine, but spits this warning:

ERROR: The each() function is deprecated. This message will be suppressed on further calls 
in phar:///usr/local/bin/robo/vendor/natxet/cssmin/src/CssMin.php:2222

On PHP 8.0 and up, it fails as each() function is removed altogether from the language:

ERROR: Uncaught Error: Call to undefined function each() 
in phar:///usr/local/bin/robo/vendor/natxet/cssmin/src/CssMin.php:2222

Basically, the CSS library natxet/CssMin needs to be upgraded.

What's the best way to achieve this? I'm up to put some work on this is necessary.

@greg-1-anderson
Copy link
Member

A PR would be welcome. Check to see if there is a newer version of the library that supports PHP 8. It could be as easy as adjusting the version constraint in Robo's composer.json and running composer update. Some code changes in Robo might be necessary after the upgrade, if APIs changed at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants