Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cachi2 should also cache bundler of the locked version #755

Open
gsaslis opened this issue Nov 29, 2024 · 1 comment
Open

cachi2 should also cache bundler of the locked version #755

gsaslis opened this issue Nov 29, 2024 · 1 comment

Comments

@gsaslis
Copy link
Contributor

gsaslis commented Nov 29, 2024

This issue was originally reported by @akostadinov on the Cachito issue tracker. I am recreating the feature request here.

cachi2 presently does not cache bundler because it is usually (or never?) not pinned as a dependency with version in the Gemfile.lock [1].

But it is important for the same version of bundler to be installable and used for resolving dependencies.

At the bottom of a Gemfile.lock, there is

BUNDLED WITH
2.3.4
Cachito needs to cache bundler of this version so that builds can install it into the system. Using the bundler from the build image does not usually fit.

P.S. If BUNDLED WITH is not present, only then do not cache bundler. For example if project uses gem install -g instead of bundle install.

Acceptance criteria

As an additional piece of information, I wanted to add that the capability to parse the BUNDLED WITH information has already been contributed (and merged!) to the upstream projects, so that it can be used by cachi2.

@akostadinov
Copy link

FYI the gemlock-parser already has BUNDLED WITH support applied with containerbuildsystem/gemlock-parser#3

So the only further change needed is with cachi2, regards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants