-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Launched plugins Stdout/Stderr are dropped #65
Comments
This was a conscious choice to avoid, for instance, proxying log messages through the runtime. The idea was that the plugins will set up and take care of their own logging using syslog(3). We can update the stub so that it automatically sets up logging via syslog, when the plugin is launched by the runtime. |
The big limitation of using syslog is that panic text is not logged, or at least need some more work (in 1.23 we will have SetCrashOutput) |
Or you mean redirecting stdout / stderr to syslog in plugin.go and not in each plugins ? |
No, I mean in the pkg/stub, which is then on the plugin side... |
nri/pkg/adaptation/plugin.go
Line 119 in 6f5a4d2
cmd.Stdout/Stderr are nil, so everything goes to /dev/null
The text was updated successfully, but these errors were encountered: