Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] Templates for Pull Requests #104

Open
manugupt1 opened this issue Jan 6, 2023 · 2 comments
Open

[Proposal] Templates for Pull Requests #104

manugupt1 opened this issue Jan 6, 2023 · 2 comments

Comments

@manugupt1
Copy link

Nerdctl contributors were recently talking about having pull request templates / good commit messages. One thing that was proposed was Github PR templates

https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-an[…]requests/creating-a-pull-request-template-for-your-repository

The PR template can ask the following questions:

  • What is the change?
  • Why is the change important (can be fixes something)?
  • Any gotchas to be aware of?

cc @containerd/nerdctl-committers & @containerd/nerdctl-maintainers

@samuelkarp
Copy link
Member

Is the suggestion here to have a common pull request template for each containerd subproject?

@manugupt1
Copy link
Author

I think having a common template would make most sense; but I am not sure of the entire context of the how the project operates to make a call. I opened this to get some feedback from members.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants