Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

need investigate: cross test failed with exit code 0 #685

Closed
Mossaka opened this issue Oct 1, 2024 · 5 comments · Fixed by #737
Closed

need investigate: cross test failed with exit code 0 #685

Mossaka opened this issue Oct 1, 2024 · 5 comments · Fixed by #737
Labels
good first issue Good for newcomers

Comments

@Mossaka
Copy link
Member

Mossaka commented Oct 1, 2024

run: https://github.com/containerd/runwasi/actions/runs/11112905312/job/30876017101?pr=682#step:9:373

Originally posted by @Mossaka in #682 (comment)

@Mossaka Mossaka added the good first issue Good for newcomers label Oct 1, 2024
@fawadasaurus
Copy link
Contributor

fawadasaurus commented Oct 6, 2024

I spent some time on this. I believe that the root cause may actually be an open issue with buildx: docker/buildx#732

@Mossaka
Copy link
Member Author

Mossaka commented Nov 16, 2024

What would you suggest as a walkaround? @fawadasaurus

@fawadasaurus
Copy link
Contributor

Github now offers ARM64 (in addition to AMD64) runners for Windows and Linux. So would it be viable to use a matrix of different runners for builds / tests?

I am curious if using the native runner for each build/test is a viable alternative to Cross and meets the needs that originally led to using Cross.

What do you think @Mossaka ?

@Mossaka Mossaka linked a pull request Nov 18, 2024 that will close this issue
@Mossaka
Copy link
Member Author

Mossaka commented Nov 18, 2024

I think one of the goals to use cross is that we want to build statically-linked binaries. But I agree with you that we may investigate native runners for each build/test.

Jorge had a PR #737 that fixed this issue.

@jprendes
Copy link
Collaborator

We currently do not run the tests in arm64, using native runners would be interesting if it allows us to run them.

The reason not to run them in arm64 is because cross uses qemu to run the tests when the arch doesn't match, and that didn't translate properly to the syscalls we use to create the containers. Using native runners would fix that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants