Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correcting invalid URL for Kubernetes #124

Closed
wants to merge 4 commits into from
Closed

Correcting invalid URL for Kubernetes #124

wants to merge 4 commits into from

Conversation

aungzanbaw
Copy link

Fixed #123

@s1061123
Copy link

s1061123 commented Jul 3, 2023

Thank you fo the contribution. It looks good to me, however, your commit comment needs to be updated to have Signed-off-by: field. Please follow the following URL: https://github.com/containernetworking/cni.dev/pull/124/checks?check_run_id=14314151949, thanks!

@aungzanbaw aungzanbaw marked this pull request as draft September 11, 2023 09:01
@aungzanbaw aungzanbaw marked this pull request as ready for review September 11, 2023 09:02
aungzanbaw and others added 2 commits September 11, 2023 09:28
@aungzanbaw
Consistency format
157f852 
Signed-off-by: Aung Baw <aungzanbaw@users.noreply.github.com>
@aungzanbaw
Formatting
ca5871b 
Signed-off-by: Aung Baw <aungzanbaw@gmail.com>
@aungzanbaw
Copy link
Author

Should I close this one and PR new one @s1061123 ?

@aungzanbaw aungzanbaw closed this Sep 12, 2023
@aungzanbaw aungzanbaw deleted the patch-1 branch September 12, 2023 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

K8 URL moved
2 participants
@aungzanbaw @s1061123