Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CFP: do we need an escape-valve from GC? #1086

Open
squeed opened this issue May 6, 2024 · 1 comment
Open

CFP: do we need an escape-valve from GC? #1086

squeed opened this issue May 6, 2024 · 1 comment

Comments

@squeed
Copy link
Member

squeed commented May 6, 2024

If there are multiple runtimes using the same network configuration, then no one runtime knows the set of valid attachments. Thus, a GC call may contain an incomplete set of valid attachments, and in-use resources may get cleaned up. Not good.

We should provide administrators a way to disable GC for a given network configuration, if they know that it will be used in a manner not amenable to GC. Much the way disableCheck is implemented.

@s1061123
Copy link
Contributor

s1061123 commented May 6, 2024

I come up with alternative way to escape GC from container runtime side. Currently libcni does not have explicit GC invocation because libcni expects that container runtime should invoke GC function GCNetworkList as they want to (e.g. periodically once a hour, or on-demand) and CNI Spec does not have any requirements/recommendations for GC, to container runtime.

So once container runtime implements (i.e. calls) GC, they may introduce config options, such as GC interval or something. I just expect that container runtime config also introduce disableGC in each container runtime config when container runtime utilizes libcni's GC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants