Skip to content

Conversation

@giuseppe
Copy link
Member

@giuseppe giuseppe commented Sep 12, 2025

@giuseppe
Copy link
Member Author

@jnovy PTAL

@packit-as-a-service
Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
@Luap99
Copy link
Member

Luap99 commented Sep 12, 2025

This will not work for podman, there are normal healthchecks and startup healthchecks which can use a different interval each and only podman knows when to switch. I think this needs some larger design discussion if we would want to do it in conmon.
And if we are working towards a conmon rust rewrite does it even make sense to add such feature now in the old c version?

@mheon
Copy link
Member

mheon commented Sep 12, 2025

Concur - without some sort of signaling mechanism to indicate that we are finishing the startup healthcheck and switching to the new parameters, this will not work. Adding that seems like a lot of work for something we're not even sure we want to do (moving HCs into Conmon)

@giuseppe
Copy link
Member Author

Yes this is not complete implementation, just a couple of hours of work to realize better what is doable and if it is even worth it. Handling different intervals is possible and timers can be unregistered (missing now).

Said so, I am still not sure it is worth doing and would leave it as a systemd only feature

@giuseppe giuseppe closed this Sep 12, 2025
@mheon mheon mentioned this pull request Sep 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants