Commit 5975c29
committed
Makefile: Drop dead CONTAINER_RUNTIME
This variable is dead code as far as I can tell. I think it
got cargo culted from something similar in skopeo, where it *is*
used:
https://github.com/containers/skopeo/blob/85598438ce295fc9acdc27a1d5f97b7501f411a5/Makefile#L75
etc.
(Instead it looks like there's a `PODMANCMD` here)
But I'm effectively using this PR as a way to suggest aligning
with what we're doing in bootc, where we have a core principle
that `Makefile` should *never* itself spawn containers (or VMs etc).
All the rules in Makefile are things that should work when e.g.
building RPMs or debs or the like.
Those tasks are things that are done via `Justfile`:
https://github.com/bootc-dev/bootc/blob/main/Justfile
So for example to align, we'd add a `Justfile` here and then
`make validatepr` would move to `just validatepr`.
Signed-off-by: Colin Walters <walters@verbum.org>1 parent 6b73128 commit 5975c29
1 file changed
+0
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
96 | 96 | | |
97 | 97 | | |
98 | 98 | | |
99 | | - | |
100 | 99 | | |
101 | 100 | | |
102 | 101 | | |
| |||
0 commit comments