Fix remote exec ignoring --detach-keys option

The remote client was completely ignoring the --detach-keys option
for exec sessions. The ExecStartAndAttach() function hardcoded empty
detach keys ([]byte{}) instead of using the detach keys stored in the
exec session configuration.

Signed-off-by: shiavm006 <shivammittal42006@gmail.com>

Author: shiavm006

pkg/bindings/containers/attach.go

@@ -402,6 +402,15 @@ func ExecStartAndAttach(ctx context.Context, sessionID string, options *ExecStar
 		isTerm = respStruct.ProcessConfig.Tty
 	}
 
+	// Extract and parse detach keys from the exec session
+	detachKeysInBytes := []byte{}
+	if respStruct.DetachKeys != "" {
+		detachKeysInBytes, err = term.ToBytes(respStruct.DetachKeys)
+		if err != nil {
+			return fmt.Errorf("invalid detach keys in exec session: %w", err)
+		}
+	}
+
 	// If we are in TTY mode, we need to set raw mode for the terminal.
 	// TODO: Share all of this with Attach() for containers.
 	needTTY := terminalFile != nil && terminal.IsTerminal(int(terminalFile.Fd())) && isTerm
@@ -458,7 +467,7 @@ func ExecStartAndAttach(ctx context.Context, sessionID string, options *ExecStar
 	if options.GetAttachInput() {
 		go func() {
 			logrus.Debugf("Copying STDIN to socket")
-			_, err := detach.Copy(socket, options.InputStream, []byte{})
+			_, err := detach.Copy(socket, options.InputStream, detachKeysInBytes)
 			// Ignore "closed network connection" as it occurs when the exec ends, which is expected.
 			// This avoids noisy logs but does not fix the goroutine leak
 			// https://github.com/containers/podman/issues/25344
@@ -479,7 +488,7 @@ func ExecStartAndAttach(ctx context.Context, sessionID string, options *ExecStar
 			return fmt.Errorf("exec session %s has a terminal and must have STDOUT enabled", sessionID)
 		}
 		// If not multiplex'ed, read from server and write to stdout
-		_, err := detach.Copy(options.GetOutputStream(), socket, []byte{})
+		_, err := detach.Copy(options.GetOutputStream(), socket, detachKeysInBytes)
 		if err != nil {
 			return err
 		}

test/system/075-exec.bats

@@ -312,4 +312,23 @@ load helpers
 
     run_podman rm -f -t0 $cid
 }
+
+# bats test_tags=ci:parallel
+@test "podman exec with --detach-keys" {
+    # Start a long-running container
+    run_podman run -d $IMAGE top
+    cid="$output"
+
+    # Test with custom detach keys - should not error
+    # (actual detach behavior is hard to test in non-interactive mode,
+    # but we can verify the option is accepted)
+    run_podman exec --detach-keys="ctrl-x,ctrl-x" $cid echo "detach-keys-test"
+    is "$output" "detach-keys-test" "exec with custom detach-keys works"
+
+    # Test with empty detach keys - should not error
+    run_podman exec --detach-keys="" $cid echo "empty-detach-keys"
+    is "$output" "empty-detach-keys" "exec with empty detach-keys works"
+
+    run_podman rm -f -t0 $cid
+}
 # vim: filetype=sh