Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFE] docker client - do not read $HOME/.docker/config.json #106

Closed
runcom opened this issue Jun 16, 2016 · 2 comments · Fixed by containers/image#113
Closed

[RFE] docker client - do not read $HOME/.docker/config.json #106

runcom opened this issue Jun 16, 2016 · 2 comments · Fixed by containers/image#113
Labels
kind/feature A request for, or a PR adding, new functionality locked - please file new issue/PR

Comments

@runcom
Copy link
Member

runcom commented Jun 16, 2016

it's ugly that a library is retrieving credentials from something on the host w/o users noticing. I think we should find a way to abstract credentials and put them directly on ImageSource initialization

@runcom runcom changed the title [RFE] docker/docker_client.go credentials store support [RFE] docker client - do not read $HOME/.docker/config.json Jun 16, 2016
@mtrmac
Copy link
Contributor

mtrmac commented Jun 28, 2016

Hum, but the default implementation should still read that file (or whatever docker login sets up), right?

Equally, it would be nice to have a reliable way to run in-process unit tests which do not touch the home directory.

I am currently looking at how parseImage… get their certPath and tlsVerify parameters, which is ugly to pass down into ImageSource. I guess we would benefit from a SystemContext / OuterWorldConfiguration / HereYouCanAskAboutYourEnvironment (all silly names, I know, there must be a better one) structure to create per-process and to pass to the ImageSource/ImageDestination constructors.

@runcom
Copy link
Member Author

runcom commented Jun 28, 2016

SystemContext

+1000

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature A request for, or a PR adding, new functionality locked - please file new issue/PR
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants