-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade dependencies. #1170
Upgrade dependencies. #1170
Conversation
I just noticed that there's an issue in go-marathon when build with Go 1.8. Will fix it first upstream and then update this PR. |
This is ready for review again. The reason for the delay was that Go 1.8 brought in a change to the I pushed another commit which pulls in go-marathon 0.7.1 and contains the fix. Please don't mind the now-wrong branch name. :-) @containous/traefik Please take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🐸
I wish we would pin them to this hash to make sure another glide up
somewhere else won't bring back the wrong hash but meh 🐮
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👼
4c22c15
to
eb2c717
Compare
@@ -1,5 +1,5 @@ | |||
hash: b2ac93355c3f551a75216a800337cee9321f6c9a04a18ab1fa8d8152e89b7595 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@timoreimann Not sure why the hash is unchanged here 🤔 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The hash is based on the content of the glide.yaml file. However, the manifest file did not change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In particular, go-marathon's version is specified as ^0.5.1
in glide.yaml, which is still valid given the latest version is 0.7.1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, indeed ;)
eb2c717
to
e4bfb52
Compare
Squashed two latest commits and rebased. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @timoreimann :)
We could! No? |
I could follow up with another PR to raise the minimum version to 0.7.1 if you like. |
e4bfb52
to
9bb1b01
Compare
Brings github.com/gambol99/go-marathon version 0.7.1.
@emilevauge @vdemeester @SantoDE Good to merge? Again, happy to bump the minimum go-marathon version either in this PR or a follow-up. Just let me know. |
Brings github.com/gambol99/go-marathon version
0.7.00.7.1 (updated, see my comment below).I previously merged a PR on go-marathon which exposes the task state, which can now be used in Marathon templates. See the upstream PR description for my motivation why I'd like to have the state in Traefik.
Other (auto-)changes to the glide.lock file include upgrading to a later 1.5 client-go commit and removal of an apparently unused dependency (go-metrics).