-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update TLS Ciphers for Go 1.8 #1276
Conversation
00c561d
to
7c765c2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
d0e741e
to
1140ee6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM based on rebasing this on master once #1259 is merged ...
7c765c2
to
1ed68b1
Compare
when will this be released? |
The upcoming 1.3 release will have it. |
That is the release cadence? |
I think it's scheduled for some time at the end of this month. We're still in the process to finding a good cadence, hence we haven't published release schedules yet (but will do so eventually). |
thanks for letting me know! |
I'm a bit worried that the list of ciphers fall behind what's actually available. Perhaps a more dynamic way of extracting what Go supports would be in place? |
@jmagnusson we might be able to use reflection to achieve that. Alternatively, we put a big red sign right before the Go version specifier in the Go builder Docker image we use that says something like "do not update without updating the TLS ciphers too". Regardless of what the best approach is, you are raising a valid point. Would you mind filing an issue? |
See #1268 . This is an update to include all supported TLS ciphers in Go 1.8.
There are no cipher removals, only additions.