Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TLS Ciphers for Go 1.8 #1276

Merged
merged 1 commit into from
Mar 24, 2017

Conversation

kekoav
Copy link
Contributor

@kekoav kekoav commented Mar 13, 2017

See #1268 . This is an update to include all supported TLS ciphers in Go 1.8.

There are no cipher removals, only additions.

Copy link
Contributor

@timoreimann timoreimann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@emilevauge?

Copy link
Contributor

@errm errm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM based on rebasing this on master once #1259 is merged ...

@timoreimann timoreimann changed the base branch from bump-go-1.8 to master March 24, 2017 08:35
@timoreimann timoreimann merged commit 1cf1fbf into traefik:master Mar 24, 2017
@kostyrev
Copy link

when will this be released?

@timoreimann
Copy link
Contributor

The upcoming 1.3 release will have it.

@kostyrev
Copy link

That is the release cadence?

@timoreimann
Copy link
Contributor

I think it's scheduled for some time at the end of this month. We're still in the process to finding a good cadence, hence we haven't published release schedules yet (but will do so eventually).

@kostyrev
Copy link

thanks for letting me know!

@ldez ldez added this to the 1.3 milestone Apr 23, 2017
@jacobsvante
Copy link

I'm a bit worried that the list of ciphers fall behind what's actually available. Perhaps a more dynamic way of extracting what Go supports would be in place?

@timoreimann
Copy link
Contributor

@jmagnusson we might be able to use reflection to achieve that. Alternatively, we put a big red sign right before the Go version specifier in the Go builder Docker image we use that says something like "do not update without updating the TLS ciphers too".

Regardless of what the best approach is, you are raising a valid point. Would you mind filing an issue?

@ldez ldez added the kind/enhancement a new or improved feature. label Apr 29, 2017
@ldez ldez modified the milestones: 1.2, 1.3 Apr 29, 2017
@ldez ldez modified the milestones: 1.3, 1.2 May 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement a new or improved feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants